Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vueify Visualizations Grid #16892

Merged
merged 97 commits into from
Nov 20, 2023
Merged

Vueify Visualizations Grid #16892

merged 97 commits into from
Nov 20, 2023

Conversation

guerler
Copy link
Contributor

@guerler guerler commented Oct 20, 2023 •
edited
Loading

This PR adds FastAPI endpoints for the visualization indices, additionally it replaces the legacy backbone based grid for Visualizations and Published Visualizations with a re-usable Vue grid component. The backbone-based grid-shared module has been removed.

image

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler added this to the 23.2 milestone Oct 20, 2023
@guerler guerler force-pushed the grids_vue branch 3 times, most recently from 2d0ff27 to 98dee93 Compare October 21, 2023 07:14
@guerler guerler force-pushed the grids_vue branch 11 times, most recently from a9e286c to ad74ad2 Compare October 27, 2023 05:55
@guerler guerler marked this pull request as ready for review October 27, 2023 10:43
@guerler guerler force-pushed the grids_vue branch 8 times, most recently from 7ef7aba to c7dbcaf Compare November 14, 2023 05:56
@guerler guerler mentioned this pull request Nov 15, 2023
Merged
4 tasks
ElectronicBlueberry
ElectronicBlueberry reviewed Nov 15, 2023
View reviewed changes
client/src/components/Grid/GridElements/GridLink.vue Outdated Show resolved Hide resolved
client/src/components/Grid/GridElements/GridLink.vue Outdated Show resolved Hide resolved
client/src/components/Grid/GridList.vue Outdated Show resolved Hide resolved
client/src/components/Grid/GridList.vue Outdated Show resolved Hide resolved
client/src/components/Grid/GridElements/GridOperations.vue Outdated Show resolved Hide resolved
client/src/components/Grid/GridElements/GridOperations.vue Outdated Show resolved Hide resolved
client/src/components/Grid/GridElements/GridText.vue Outdated Show resolved Hide resolved
client/src/components/Indices/SharingIndicators.vue Outdated Show resolved Hide resolved
@guerler guerler force-pushed the grids_vue branch 2 times, most recently from 4df826a to 0af7d58 Compare November 16, 2023 05:54
@dannon dannon merged commit 1666892 into galaxyproject:dev Nov 20, 2023
51 checks passed
ElectronicBlueberry
ElectronicBlueberry reviewed Nov 20, 2023
View reviewed changes
Copy link
Member

@ElectronicBlueberry ElectronicBlueberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was still reviewing this. But it's fine for me to handle the following comments in a followup PR.

client/src/components/Grid/GridList.vue Show resolved Hide resolved
client/src/utils/timeout.ts Show resolved Hide resolved
@dannon
Copy link
Member

dannon commented Nov 20, 2023

I was still reviewing this. But it's fine for me to handle the following comments in a followup PR.

Sorry! Feel free to indicate that in a comment or something next time -- I saw it had been sitting a few days and gave it a quick test. I noticed a few things to follow up on in the vue3 branch as well.

@guerler guerler deleted the grids_vue branch November 21, 2023 06:56
@guerler
Copy link
Contributor Author

guerler commented Nov 23, 2023

Thanks for the review. I followed up by resolving the additional comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davelopez davelopez davelopez left review comments

@ElectronicBlueberry ElectronicBlueberry ElectronicBlueberry left review comments

@mvdbeek mvdbeek mvdbeek approved these changes

@dannon dannon dannon approved these changes

Assignees
No one assigned
Labels
area/API area/backend area/UI-UX kind/enhancement
Projects
None yet
Milestone
23.2
Development

Successfully merging this pull request may close these issues.
6 participants
@guerler @dannon @mvdbeek @ElectronicBlueberry @davelopez @ahmedhamidawan